From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Sun, 25 Jun 2006 12:48:45 +0000 (-0700)
Subject: [PATCH] Cyclades Cleanup
X-Git-Tag: v2.6.18-rc1~929
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=969dd061d81d9e2bc7f954859452ac81cc639711;p=linux-2.6-omap-h63xx.git

[PATCH] Cyclades Cleanup

coverity choked at two !tty checks, in places where tty can never be NULL.
Since it removes some code we should remove these checks.  (Coverity ids
#763,#762)

[akpm@osdl.org: even cleaner!]
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index cc7acf877dc..122e7a72a4e 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -2833,9 +2833,8 @@ cy_write(struct tty_struct * tty, const unsigned char *buf, int count)
         return 0;
     }
         
-    if (!tty || !info->xmit_buf || !tmp_buf){
-        return 0;
-    }
+    if (!info->xmit_buf || !tmp_buf)
+	return 0;
 
     CY_LOCK(info, flags);
     while (1) {
@@ -2884,7 +2883,7 @@ cy_put_char(struct tty_struct *tty, unsigned char ch)
     if (serial_paranoia_check(info, tty->name, "cy_put_char"))
         return;
 
-    if (!tty || !info->xmit_buf)
+    if (!info->xmit_buf)
         return;
 
     CY_LOCK(info, flags);