From: Dave Kleikamp Date: Thu, 8 Jan 2009 15:46:31 +0000 (-0600) Subject: async: Don't call async_synchronize_full_special() while holding sb_lock X-Git-Tag: v2.6.29-rc1~174 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=96777fe7b042e5a5d0fe5fb861fcd6cd80ef9634;p=linux-2.6-omap-h63xx.git async: Don't call async_synchronize_full_special() while holding sb_lock sync_filesystems() shouldn't be calling async_synchronize_full_special while holding a spinlock. The second while loop in that function is the right place for this anyway. Signed-off-by: Dave Kleikamp Cc: Arjan van de Ven Reported-by: Grissiom Signed-off-by: Linus Torvalds --- diff --git a/fs/super.c b/fs/super.c index cb20744ec78..7d67387496c 100644 --- a/fs/super.c +++ b/fs/super.c @@ -458,7 +458,6 @@ void sync_filesystems(int wait) if (sb->s_flags & MS_RDONLY) continue; sb->s_need_sync_fs = 1; - async_synchronize_full_special(&sb->s_async_list); } restart: @@ -471,6 +470,7 @@ restart: sb->s_count++; spin_unlock(&sb_lock); down_read(&sb->s_umount); + async_synchronize_full_special(&sb->s_async_list); if (sb->s_root && (wait || sb->s_dirt)) sb->s_op->sync_fs(sb, wait); up_read(&sb->s_umount);