From: Jean Delvare <khali@linux-fr.org>
Date: Thu, 23 Nov 2006 19:48:28 +0000 (-0800)
Subject: [6PACK]: Masking bug in 6pack driver.
X-Git-Tag: v2.6.19~19^2~2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=95f6134e175fd69ab3f088f7a09adbd3fd3548e1;p=linux-2.6-omap-h63xx.git

[6PACK]: Masking bug in 6pack driver.

Looks like a broken masking to me, binary not is used where bitwise
not was intended.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c
index 86b3bb9bec2..92420f007b9 100644
--- a/drivers/net/hamradio/6pack.c
+++ b/drivers/net/hamradio/6pack.c
@@ -914,7 +914,7 @@ static void decode_prio_command(struct sixpack *sp, unsigned char cmd)
 					printk(KERN_DEBUG "6pack: protocol violation\n");
 				else
 					sp->status = 0;
-				cmd &= !SIXP_RX_DCD_MASK;
+				cmd &= ~SIXP_RX_DCD_MASK;
 		}
 		sp->status = cmd & SIXP_PRIO_DATA_MASK;
 	} else { /* output watchdog char if idle */