From: Micah Gruber <micah.gruber@gmail.com>
Date: Mon, 23 Jul 2007 08:05:52 +0000 (+0800)
Subject: Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net... 
X-Git-Tag: v2.6.23-rc2~148^2~16
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9351982b25ace7ee5ed82b6f4a7ea1151f31d267;p=linux-2.6-omap-h63xx.git

Fix a potential NULL pointer dereference in write_bulk_callback() in drivers/net/usb/pegasus.c

This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing
after the null check.

Signed-off-by: Micah Gruber <micah.gruber@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index a05fd97e5bc..04cba6bf3d5 100644
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -768,11 +768,13 @@ done:
 static void write_bulk_callback(struct urb *urb)
 {
 	pegasus_t *pegasus = urb->context;
-	struct net_device *net = pegasus->net;
+	struct net_device *net;
 
 	if (!pegasus)
 		return;
 
+	net = pegasus->net;
+
 	if (!netif_device_present(net) || !netif_running(net))
 		return;