From: Francois Romieu Date: Fri, 13 Jul 2007 21:05:35 +0000 (+0200) Subject: 8139cp: implement the missing dev->tx_timeout X-Git-Tag: v2.6.23-rc1~768^2~9 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=9030c0d24dbb90bbe6b31dc93c3be5e36290c7c3;p=linux-2.6-omap-h63xx.git 8139cp: implement the missing dev->tx_timeout Signed-off-by: Mika Lansirinne Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 58bbc3e6d0d..f5223eca2f7 100644 --- a/drivers/net/8139cp.c +++ b/drivers/net/8139cp.c @@ -26,7 +26,6 @@ TODO: * Test Tx checksumming thoroughly - * Implement dev->tx_timeout Low priority TODO: * Complete reset on PciErr @@ -1218,6 +1217,30 @@ static int cp_close (struct net_device *dev) return 0; } +static void cp_tx_timeout(struct net_device *dev) +{ + struct cp_private *cp = netdev_priv(dev); + unsigned long flags; + int rc; + + printk(KERN_WARNING "%s: Transmit timeout, status %2x %4x %4x %4x\n", + dev->name, cpr8(Cmd), cpr16(CpCmd), + cpr16(IntrStatus), cpr16(IntrMask)); + + spin_lock_irqsave(&cp->lock, flags); + + cp_stop_hw(cp); + cp_clean_rings(cp); + rc = cp_init_rings(cp); + cp_start_hw(cp); + + netif_wake_queue(dev); + + spin_unlock_irqrestore(&cp->lock, flags); + + return; +} + #ifdef BROKEN static int cp_change_mtu(struct net_device *dev, int new_mtu) { @@ -1923,10 +1946,8 @@ static int cp_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) dev->change_mtu = cp_change_mtu; #endif dev->ethtool_ops = &cp_ethtool_ops; -#if 0 dev->tx_timeout = cp_tx_timeout; dev->watchdog_timeo = TX_TIMEOUT; -#endif #if CP_VLAN_TAG_USED dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;