From: Wu Fengguang Date: Thu, 27 Nov 2008 10:42:22 +0000 (+0100) Subject: trivial: radix-tree: document wrap-around issue of radix_tree_next_hole() X-Git-Tag: v2.6.29-rc1~197^2~22 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=8e6bdb7f8b478323525444ecee7a1477ff5b6639;p=linux-2.6-omap-h63xx.git trivial: radix-tree: document wrap-around issue of radix_tree_next_hole() And some 80-line cleanups. Signed-off-by: Wu Fengguang Signed-off-by: Jiri Kosina --- diff --git a/lib/radix-tree.c b/lib/radix-tree.c index be86b32bc87..a7f5217dd67 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c @@ -640,13 +640,14 @@ EXPORT_SYMBOL(radix_tree_tag_get); * * Returns: the index of the hole if found, otherwise returns an index * outside of the set specified (in which case 'return - index >= max_scan' - * will be true). + * will be true). In rare cases of index wrap-around, 0 will be returned. * * radix_tree_next_hole may be called under rcu_read_lock. However, like - * radix_tree_gang_lookup, this will not atomically search a snapshot of the - * tree at a single point in time. For example, if a hole is created at index - * 5, then subsequently a hole is created at index 10, radix_tree_next_hole - * covering both indexes may return 10 if called under rcu_read_lock. + * radix_tree_gang_lookup, this will not atomically search a snapshot of + * the tree at a single point in time. For example, if a hole is created + * at index 5, then subsequently a hole is created at index 10, + * radix_tree_next_hole covering both indexes may return 10 if called + * under rcu_read_lock. */ unsigned long radix_tree_next_hole(struct radix_tree_root *root, unsigned long index, unsigned long max_scan)