From: Oleg Nesterov Date: Fri, 25 Jul 2008 08:47:49 +0000 (-0700) Subject: workqueues: schedule_on_each_cpu: use flush_work() X-Git-Tag: v2.6.27-rc1~332 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=8616a89ab761239c963eea3a63be383f127cc7e8;p=linux-2.6-omap-h63xx.git workqueues: schedule_on_each_cpu: use flush_work() Change schedule_on_each_cpu() to use flush_work() instead of flush_workqueue(), this way we don't wait for other work_struct's which can be queued meanwhile. Signed-off-by: Oleg Nesterov Cc: Jarek Poplawski Cc: Max Krasnyansky Cc: Peter Zijlstra Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/kernel/workqueue.c b/kernel/workqueue.c index ee41cf857d5..5fbffd302eb 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -690,7 +690,8 @@ int schedule_on_each_cpu(work_func_t func) set_bit(WORK_STRUCT_PENDING, work_data_bits(work)); __queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work); } - flush_workqueue(keventd_wq); + for_each_online_cpu(cpu) + flush_work(per_cpu_ptr(works, cpu)); put_online_cpus(); free_percpu(works); return 0;