From: Peter Staubach Date: Fri, 17 Mar 2006 07:04:02 +0000 (-0800) Subject: [PATCH] nfsservctl(): remove user-triggerable printk X-Git-Tag: v2.6.16~11 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=85c6932ef0c7a82c309f8728ddf29768001d794e;p=linux-2.6-omap-h63xx.git [PATCH] nfsservctl(): remove user-triggerable printk A user can use nfsservctl() to spam the logs. This can happen because the arguments to the nfsservctl() system call are versioned. This is a good thing. However, when a bad version is detected, the kernel prints a message and then returns an error. Signed-off-by: Peter Staubach Cc: Trond Myklebust Cc: Neil Brown Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/nfsctl.c b/fs/nfsctl.c index 0d4cf948606..1c72c7f85dd 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c @@ -98,10 +98,8 @@ asmlinkage sys_nfsservctl(int cmd, struct nfsctl_arg __user *arg, void __user *r if (copy_from_user(&version, &arg->ca_version, sizeof(int))) return -EFAULT; - if (version != NFSCTL_VERSION) { - printk(KERN_WARNING "nfsd: incompatible version in syscall.\n"); + if (version != NFSCTL_VERSION) return -EINVAL; - } if (cmd < 0 || cmd >= sizeof(map)/sizeof(map[0]) || !map[cmd].name) return -EINVAL;