From: Jay Fenlason <fenlason@redhat.com>
Date: Mon, 8 Oct 2007 21:00:29 +0000 (-0400)
Subject: firewire: fw-cdev: reorder wakeup vs. spinlock
X-Git-Tag: v2.6.24-rc1~825^2
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=83431cba3d847fc2296d3f38ce7feb623a1cfc45;p=linux-2.6-omap-h63xx.git

firewire: fw-cdev: reorder wakeup vs. spinlock

Signed-off-by: Jay Fenlason <fenlason@redhat.com>

Prompted by https://bugzilla.redhat.com/show_bug.cgi?id=323411

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c
index 290d9f03619..60f1a8924a9 100644
--- a/drivers/firewire/fw-cdev.c
+++ b/drivers/firewire/fw-cdev.c
@@ -143,11 +143,10 @@ static void queue_event(struct client *client, struct event *event,
 	event->v[1].size = size1;
 
 	spin_lock_irqsave(&client->lock, flags);
-
 	list_add_tail(&event->link, &client->event_list);
-	wake_up_interruptible(&client->wait);
-
 	spin_unlock_irqrestore(&client->lock, flags);
+
+	wake_up_interruptible(&client->wait);
 }
 
 static int