From: Dmitry Monakhov <dmonakhov@sw.ru>
Date: Tue, 16 Oct 2007 08:25:02 +0000 (-0700)
Subject: deny partial write for loop dev fd
X-Git-Tag: v2.6.24-rc1~1198
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=8268f5a7415d914fc855a86aa2284ac819dc6b2e;p=linux-2.6-omap-h63xx.git

deny partial write for loop dev fd

Partial write can be easily supported by LO_CRYPT_NONE mode, but it is not
easy in LO_CRYPT_CRYPTOAPI case, because of its block nature.  I don't know
who still used cryptoapi, but theoretically it is possible.  So let's leave
things as they are.  Loop device doesn't support partial write before
Nick's "write_begin/write_end" patch set, and let's it behave the same way
after.

Signed-off-by: Dmitriy Monakhov <dmonakhov@openvz.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index a5f993ac28d..e5a051577a5 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -245,10 +245,8 @@ static int do_lo_send_aops(struct loop_device *lo, struct bio_vec *bvec,
 
 		ret = pagecache_write_end(file, mapping, pos, size, copied,
 							page, fsdata);
-		if (ret < 0)
+		if (ret < 0 || ret != copied)
 			goto fail;
-		if (ret < copied)
-			copied = ret;
 
 		if (unlikely(transfer_result))
 			goto fail;