From: Riku Voipio <riku.voipio@iki.fi>
Date: Tue, 3 Mar 2009 20:13:06 +0000 (+0200)
Subject: leds: Fix &&/|| confusion in leds-pca9532.c
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=7fbc3a9b132e93b2ba1fd889c1ad8a4135731cc3;p=linux-2.6-omap-h63xx.git

leds: Fix &&/|| confusion in leds-pca9532.c

This fixes the expression in the driver to do the correct thing,
not that I think anyone would send SND_* without EV_SND.

Thanks to Roel Kluin <roel.kluin@gmail.com> for noticing.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
---

diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index bd3b431c971..3937244fdca 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -169,7 +169,7 @@ static int pca9532_event(struct input_dev *dev, unsigned int type,
 {
 	struct pca9532_data *data = input_get_drvdata(dev);
 
-	if (type != EV_SND && (code != SND_BELL || code != SND_TONE))
+	if (!(type == EV_SND && (code == SND_BELL || code == SND_TONE)))
 		return -1;
 
 	/* XXX: allow different kind of beeps with psc/pwm modifications */