From: Tejun Heo <htejun@gmail.com>
Date: Wed, 13 Feb 2008 09:20:19 +0000 (+0900)
Subject: pata_legacy: don't call ata_host_detach() after initialization failure
X-Git-Tag: v2.6.25-rc3~137^2~7
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=7a3a16fe7ddf0570e2fcf286d7e244a5e1e16f6a;p=linux-2.6-omap-h63xx.git

pata_legacy: don't call ata_host_detach() after initialization failure

ata_host_detach() detaches an attached port and shouldn't be called on
a port which hasn't been attached yet.  pata_legacy incorrectly calls
ata_host_detach() on unattached port after initialization failure
causing oops.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 6c59969fd50..d2177f75078 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -1278,8 +1278,6 @@ static __init int legacy_init_one(struct legacy_probe *probe)
 		}
 	}
 fail:
-	if (host)
-		ata_host_detach(host);
 	platform_device_unregister(pdev);
 	return ret;
 }