From: Vivek Goyal <vgoyal@in.ibm.com>
Date: Thu, 7 Dec 2006 01:14:10 +0000 (+0100)
Subject: [PATCH] i386: Convert more absolute symbols to section relative
X-Git-Tag: v2.6.20-rc1~145^2^2~8^2~51
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=79929fd1c1887d2a057cbb80d487a2e2f1c01a02;p=linux-2.6-omap-h63xx.git

[PATCH] i386: Convert more absolute symbols to section relative

o Convert more absolute symbols to section relative to keep the theme in
  vmlinux.lds.S file and to avoid problem if kernel is relocated.

o Also put a message so that in future people can be aware of it and
  avoid introducing absolute symbols.

Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

diff --git a/arch/i386/kernel/vmlinux.lds.S b/arch/i386/kernel/vmlinux.lds.S
index 877dc5cfe3a..25581e87c60 100644
--- a/arch/i386/kernel/vmlinux.lds.S
+++ b/arch/i386/kernel/vmlinux.lds.S
@@ -8,6 +8,12 @@
  * put it inside the section definition.
  */
 
+/* Don't define absolute symbols until and unless you know that symbol
+ * value is should remain constant even if kernel image is relocated
+ * at run time. Absolute symbols are not relocated. If symbol value should
+ * change if kernel is relocated, make the symbol section relative and
+ * put it inside the section definition.
+ */
 #define LOAD_OFFSET __PAGE_OFFSET
 
 #include <asm-generic/vmlinux.lds.h>
@@ -65,11 +71,11 @@ SECTIONS
 	CONSTRUCTORS
 	} :data
 
-  __start_paravirtprobe = .;
   .paravirtprobe : AT(ADDR(.paravirtprobe) - LOAD_OFFSET) {
+  	__start_paravirtprobe = .;
 	*(.paravirtprobe)
+  	__stop_paravirtprobe = .;
   }
-  __stop_paravirtprobe = .;
 
   . = ALIGN(4096);
   .data_nosave : AT(ADDR(.data_nosave) - LOAD_OFFSET) {
@@ -172,11 +178,11 @@ SECTIONS
 	*(.altinstr_replacement)
   }
   . = ALIGN(4);
-  __start_parainstructions = .;
   .parainstructions : AT(ADDR(.parainstructions) - LOAD_OFFSET) {
+  	__start_parainstructions = .;
 	*(.parainstructions)
+  	__stop_parainstructions = .;
   }
-  __stop_parainstructions = .;
   /* .exit.text is discard at runtime, not link time, to deal with references
      from .altinstructions and .eh_frame */
   .exit.text : AT(ADDR(.exit.text) - LOAD_OFFSET) { *(.exit.text) }