From: Uwe Kleine-König Date: Sun, 21 Sep 2008 21:52:08 +0000 (+0200) Subject: avr32: Use platform_driver_probe for pdc platform driver X-Git-Tag: v2.6.28-rc1~700^2~6 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=787928e7473246991177e8cd7eeaf4cb1b3a8fbc;p=linux-2.6-omap-h63xx.git avr32: Use platform_driver_probe for pdc platform driver The probe function of the pdc platform driver lives in the init section and so a pdc device that is created after the init section is discarded probably results in an oops. Even if this cannot happen, using platform_driver_probe is cleaner. (If this can happen and should be supported the probe function must live in the devinit section instead.) Signed-off-by: Uwe Kleine-König Signed-off-by: Haavard Skinnemoen --- diff --git a/arch/avr32/mach-at32ap/pdc.c b/arch/avr32/mach-at32ap/pdc.c index 1040bda4fda..61ab15aae97 100644 --- a/arch/avr32/mach-at32ap/pdc.c +++ b/arch/avr32/mach-at32ap/pdc.c @@ -35,7 +35,6 @@ static int __init pdc_probe(struct platform_device *pdev) } static struct platform_driver pdc_driver = { - .probe = pdc_probe, .driver = { .name = "pdc", }, @@ -43,6 +42,6 @@ static struct platform_driver pdc_driver = { static int __init pdc_init(void) { - return platform_driver_register(&pdc_driver); + return platform_driver_probe(&pdc_driver, pdc_probe); } arch_initcall(pdc_init);