From: Stephen Hemminger Date: Sun, 24 Feb 2008 03:51:59 +0000 (-0800) Subject: tg3: ethtool phys_id default X-Git-Tag: v2.6.25-rc3~9^2~5 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=759afc31332aed66bde20743e7e2d1e47b08aaeb;p=linux-2.6-omap-h63xx.git tg3: ethtool phys_id default When asked to blink LEDs the tg3 driver behaves when using: ethtool -p ethX The default value for data is zero, and other drivers interpret this as blink forever (or at least a really long time). The tg3 driver interprets this as blink once. All drivers should have the same behaviour. Signed-off-by: Stephen Hemminger Acked-by: Michael Chan Signed-off-by: David S. Miller --- diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index db606b60388..26ffb67f1da 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -8781,7 +8781,7 @@ static int tg3_phys_id(struct net_device *dev, u32 data) return -EAGAIN; if (data == 0) - data = 2; + data = UINT_MAX / 2; for (i = 0; i < (data * 2); i++) { if ((i % 2) == 0)