From: Steven Noonan Date: Wed, 1 Oct 2008 08:50:25 +0000 (-0700) Subject: sdhci: 'scratch' may be used uninitialized X-Git-Tag: v2.6.28-rc1~701^2~3 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=7244b85bd17313d7d300ee93ec7bfbca1f4ccf3d;p=linux-2.6-omap-h63xx.git sdhci: 'scratch' may be used uninitialized The variable 'scratch' is always initialized before it's used. The conditional which is responsible for initialization of 'scratch' will always evaluate 'true' when the first loop iteration occurs, and thus, it's properly initialized. GCC doesn't see this, of course, so using the uninitialized_var() macro seems to work for silencing this case. Signed-off-by: Steven Noonan Signed-off-by: Pierre Ossman --- diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 3c808d22f9d..30f64b1f235 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -177,7 +177,7 @@ static void sdhci_read_block_pio(struct sdhci_host *host) { unsigned long flags; size_t blksize, len, chunk; - u32 scratch; + u32 uninitialized_var(scratch); u8 *buf; DBG("PIO reading\n");