From: Jayachandran C <c.jayachandran@gmail.com>
Date: Fri, 6 Jan 2006 08:19:54 +0000 (-0800)
Subject: [PATCH] kernel/module.c: removed dead code
X-Git-Tag: v2.6.16-rc1~936^2~68
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6fe2e70bbed3995d930f39452fb6ce3be7dc47dc;p=linux-2.6-omap-h63xx.git

[PATCH] kernel/module.c: removed dead code

This patch fixes an issue reported by Coverity in kernel/module.c

Error reported: Cannot reach this line of code "else return ptr;"

Patch description:
  This is the error path, so 'err' will be negative, the else case
  is not required, this patch removes it.

Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/kernel/module.c b/kernel/module.c
index 2ea929d51ad..4b06bbad49c 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1854,8 +1854,7 @@ static struct module *load_module(void __user *umod,
 	kfree(args);
  free_hdr:
 	vfree(hdr);
-	if (err < 0) return ERR_PTR(err);
-	else return ptr;
+	return ERR_PTR(err);
 
  truncated:
 	printk(KERN_ERR "Module len %lu truncated\n", len);