From: Jesper Juhl Date: Mon, 6 Aug 2007 12:05:27 +0000 (+0200) Subject: [ALSA] au88x0: mem leak fix in snd_vortex_create() X-Git-Tag: v2.6.24-rc1~832^2~212 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6ed44ad3ebec52059f6f534deeb08f1d701852c5;p=linux-2.6-omap-h63xx.git [ALSA] au88x0: mem leak fix in snd_vortex_create() In sound/pci/au88x0/au88x0.c::snd_vortex_create() : The Coverity checker found that if we allocate storage for 'chip' but then leave via the regions_out: label, then we end up leaking the storage allocated for 'chip'. I believe simply freeing 'chip' before the 'return err;' line is all we need to fix this, but please double-check me :) Signed-off-by: Jesper Juhl Signed-off-by: Takashi Iwai Signed-off-by: Jaroslav Kysela --- diff --git a/sound/pci/au88x0/au88x0.c b/sound/pci/au88x0/au88x0.c index 5ec1b6fcd54..f70286a7364 100644 --- a/sound/pci/au88x0/au88x0.c +++ b/sound/pci/au88x0/au88x0.c @@ -232,6 +232,7 @@ snd_vortex_create(struct snd_card *card, struct pci_dev *pci, vortex_t ** rchip) pci_disable_device(chip->pci_dev); //FIXME: this not the right place to unregister the gameport vortex_gameport_unregister(chip); + kfree(chip); return err; }