From: Arjan van de Ven <arjan@linux.intel.com>
Date: Sun, 14 Sep 2008 02:51:30 +0000 (-0700)
Subject: proc: use WARN() rather than printk+backtrace
X-Git-Tag: v2.6.28-rc1~14^2~31
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6c2f91e077f1b60e7f83b7ee044f965f469cfdb3;p=linux-2.6-omap-h63xx.git

proc: use WARN() rather than printk+backtrace

Use WARN() rather than a printk() + backtrace();
this gives a more standard format message as well as complete
information (including line numbers etc) that will be collected
by kerneloops.org

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 7821589a17d..60a359b3558 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -547,9 +547,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp
 
 	for (tmp = dir->subdir; tmp; tmp = tmp->next)
 		if (strcmp(tmp->name, dp->name) == 0) {
-			printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
+			WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
 				dir->name, dp->name);
-			dump_stack();
 			break;
 		}