From: Allan Stephens <allan.stephens@windriver.com>
Date: Mon, 26 Jun 2006 06:44:27 +0000 (-0700)
Subject: [TIPC]: Fixed connect() to detect a dest address that is missing or too short.
X-Git-Tag: v2.6.18-rc1~614^2~27
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6b384de853c9f05e5e6da6c95edb475b96dd2cc1;p=linux-2.6-omap-h63xx.git

[TIPC]: Fixed connect() to detect a dest address that is missing or too short.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Per Liden <per.liden@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 0923213fc6a..758b2d2d2f9 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -1244,7 +1244,7 @@ static int connect(struct socket *sock, struct sockaddr *dest, int destlen,
    if (sock->state != SS_UNCONNECTED)
            return -EISCONN;
 
-   if ((dst->family != AF_TIPC) ||
+   if ((destlen < sizeof(*dst)) || (dst->family != AF_TIPC) ||
        ((dst->addrtype != TIPC_ADDR_NAME) && (dst->addrtype != TIPC_ADDR_ID)))
            return -EINVAL;