From: Dmitry Baryshkov Date: Mon, 18 Aug 2008 00:26:37 +0000 (+0400) Subject: lockdep: fix spurious 'inconsistent lock state' warning X-Git-Tag: v2.6.27-rc4~43^2 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6951b12a0fe7fc64789f2c4d62d2a304e93836a8;p=linux-2.6-omap-h63xx.git lockdep: fix spurious 'inconsistent lock state' warning Since f82b217e3513fe3af342c0f3ee1494e86250c21c lockdep can output spurious warnings related to hwirqs due to hardirq_off shrinkage from int to bit-sized flag. Guard it with double negation to fix the warning. Signed-off-by: Dmitry Baryshkov Acked-by: Peter Zijlstra Signed-off-by: Ingo Molnar --- diff --git a/kernel/lockdep.c b/kernel/lockdep.c index 77fa776a2da..3bfb1877a00 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c @@ -2582,7 +2582,7 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass, hlock->trylock = trylock; hlock->read = read; hlock->check = check; - hlock->hardirqs_off = hardirqs_off; + hlock->hardirqs_off = !!hardirqs_off; #ifdef CONFIG_LOCK_STAT hlock->waittime_stamp = 0; hlock->holdtime_stamp = sched_clock();