From: Borislav Petkov Date: Wed, 16 Jul 2008 18:33:47 +0000 (+0200) Subject: ide-floppy: zero out the whole struct ide_atapi_pc on init X-Git-Tag: v2.6.27-rc1~1049^2~10 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=68dc3575e064a5655cbd656fbf32d6ceeb85ac9e;p=linux-2.6-omap-h63xx.git ide-floppy: zero out the whole struct ide_atapi_pc on init This is a precaution just to make sure a new pc is clean when allocated. There should be no functional change introduced by this patch. [bart: ported it over IDE changes] Signed-off-by: Borislav Petkov Signed-off-by: Bartlomiej Zolnierkiewicz --- diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c index df19ede7388..00948c39822 100644 --- a/drivers/ide/ide-floppy.c +++ b/drivers/ide/ide-floppy.c @@ -351,10 +351,7 @@ static void ide_floppy_callback(ide_drive_t *drive) static void idefloppy_init_pc(struct ide_atapi_pc *pc) { - memset(pc->c, 0, 12); - pc->retries = 0; - pc->flags = 0; - pc->req_xfer = 0; + memset(pc, 0, sizeof(*pc)); pc->buf = pc->pc_buf; pc->buf_size = IDEFLOPPY_PC_BUFFER_SIZE; pc->callback = ide_floppy_callback;