From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Thu, 5 Jan 2006 20:16:41 +0000 (-0800)
Subject: [NETFILTER]: ctnetlink: remove bogus checks in ICMP protocol at dumping
X-Git-Tag: v2.6.16-rc1~474^2~21^2~21
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=684f7b296c0cb8238ce63f1828d33a00d5f3a26e;p=linux-2.6-omap-h63xx.git

[NETFILTER]: ctnetlink: remove bogus checks in ICMP protocol at dumping

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/netfilter/ip_conntrack_proto_icmp.c b/net/ipv4/netfilter/ip_conntrack_proto_icmp.c
index 5f9925db608..19cc5505558 100644
--- a/net/ipv4/netfilter/ip_conntrack_proto_icmp.c
+++ b/net/ipv4/netfilter/ip_conntrack_proto_icmp.c
@@ -279,10 +279,6 @@ static int icmp_tuple_to_nfattr(struct sk_buff *skb,
 	NFA_PUT(skb, CTA_PROTO_ICMP_CODE, sizeof(u_int8_t),
 		&t->dst.u.icmp.code);
 
-	if (t->dst.u.icmp.type >= sizeof(valid_new) 
-	    || !valid_new[t->dst.u.icmp.type])
-		return -EINVAL;
-
 	return 0;
 
 nfattr_failure: