From: Amit Shah Date: Wed, 13 Aug 2008 13:22:37 +0000 (+0300) Subject: KVM: Device assignment: Check for privileges before assigning irq X-Git-Tag: v2.6.28-rc1~269^2~86 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=6762b7299aa115e11815decd1fd982d015f09615;p=linux-2.6-omap-h63xx.git KVM: Device assignment: Check for privileges before assigning irq Even though we don't share irqs at the moment, we should ensure regular user processes don't try to allocate system resources. We check for capability to access IO devices (CAP_SYS_RAWIO) before we request_irq on behalf of the guest. Noticed by Avi. Signed-off-by: Amit Shah Signed-off-by: Avi Kivity --- diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 4a033757a19..fffdf4f69c5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -191,6 +191,11 @@ static int kvm_vm_ioctl_assign_irq(struct kvm *kvm, kvm_assigned_dev_interrupt_work_handler); if (irqchip_in_kernel(kvm)) { + if (!capable(CAP_SYS_RAWIO)) { + return -EPERM; + goto out; + } + if (assigned_irq->host_irq) match->host_irq = assigned_irq->host_irq; else