From: Eric Dumazet <dada1@cosmosbay.com>
Date: Tue, 11 Dec 2007 10:00:30 +0000 (-0800)
Subject: [NET]: dst_ifdown() cleanup
X-Git-Tag: v2.6.25-rc1~1162^2~1163
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=64b7d96167977850f4a24e52dd0a76b03c6542cf;p=linux-2.6-omap-h63xx.git

[NET]: dst_ifdown() cleanup

This cleanup shrinks size of net/core/dst.o on i386 from 1299 to 1289 bytes.
(This is because dev_hold()/dev_put() are doing atomic_inc()/atomic_dec() and
force compiler to re-evaluate memory contents.)

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/dst.c b/net/core/dst.c
index 5c6cfc4e7fd..7eceebaabaa 100644
--- a/net/core/dst.c
+++ b/net/core/dst.c
@@ -284,8 +284,8 @@ static inline void dst_ifdown(struct dst_entry *dst, struct net_device *dev,
 		dev_put(dev);
 		if (dst->neighbour && dst->neighbour->dev == dev) {
 			dst->neighbour->dev = dst->dev;
+			dev_hold(dst->dev);
 			dev_put(dev);
-			dev_hold(dst->neighbour->dev);
 		}
 	}
 }