From: Antonino A. Daplas <adaplas@gmail.com>
Date: Fri, 9 Sep 2005 20:10:02 +0000 (-0700)
Subject: [PATCH] fbdev: Initialize var structure in calc_mode_timings
X-Git-Tag: v2.6.14-rc1~306
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=61ab7903b8cd772d3bfb28bc26d02c599cfb0e5b;p=linux-2.6-omap-h63xx.git

[PATCH] fbdev: Initialize var structure in calc_mode_timings

The var structure in calc_mode_timings is not properly initialized (zero set)
which leads to undefined behavior when it is passed to fb_get_mode().

Signed-off-by: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
index 791bec3d672..713226cdf3c 100644
--- a/drivers/video/fbmon.c
+++ b/drivers/video/fbmon.c
@@ -314,11 +314,13 @@ static int edid_is_monitor_block(unsigned char *block)
 		return 0;
 }
 
-static void calc_mode_timings(int xres, int yres, int refresh, struct fb_videomode *mode)
+static void calc_mode_timings(int xres, int yres, int refresh,
+			      struct fb_videomode *mode)
 {
 	struct fb_var_screeninfo var;
 	struct fb_info info;
 	
+	memset(&var, 0, sizeof(struct fb_var_screeninfo));
 	var.xres = xres;
 	var.yres = yres;
 	fb_get_mode(FB_VSYNCTIMINGS | FB_IGNOREMON,