From: Eric Dumazet Date: Tue, 18 Dec 2007 00:19:51 +0000 (-0800) Subject: parport: "dev->timeslice" is an unsigned long, not an int X-Git-Tag: v2.6.24-rc6~50 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=60af880339aae440293a0c8e93178fdcb41f8a29;p=linux-2.6-omap-h63xx.git parport: "dev->timeslice" is an unsigned long, not an int While auditing proc_doulongvec_ms_jiffies_minmax() usage in kernel, I found a bug in drivers/parport/procfs.c, incorrectly using sizeof(int) instead of sizeof(unsigned long) Only 64bit arches are affected by this old bug. Signed-off-by: Eric Dumazet Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/parport/procfs.c b/drivers/parport/procfs.c index ed82e41210d..d950fc34320 100644 --- a/drivers/parport/procfs.c +++ b/drivers/parport/procfs.c @@ -384,7 +384,7 @@ parport_device_sysctl_template = { { .procname = "timeslice", .data = NULL, - .maxlen = sizeof(int), + .maxlen = sizeof(unsigned long), .mode = 0644, .proc_handler = &proc_doulongvec_ms_jiffies_minmax, .extra1 = (void*) &parport_min_timeslice_value,