From: Akinobu Mita <akinobu.mita@gmail.com>
Date: Fri, 22 Dec 2006 09:10:28 +0000 (-0800)
Subject: [PATCH] tlclk: delete unnecessary sysfs_remove_group
X-Git-Tag: v2.6.20-rc2~27
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=5e40508e5fee2dac7b04d5bc5b5ef3b452f0a899;p=linux-2.6-omap-h63xx.git

[PATCH] tlclk: delete unnecessary sysfs_remove_group

It is unnecessary and invalid to call sysfs_remove_group() after
sysfs_create_group() failure.

Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com>
Cc: Mark Gross <mark.gross@intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index 244d30a03fe..448d5083c38 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
 			&tlclk_attribute_group);
 	if (ret) {
 		printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
-		sysfs_remove_group(&tlclk_device->dev.kobj,
-			&tlclk_attribute_group);
 		goto out5;
 	}