From: Andrew Morton Date: Fri, 22 Dec 2006 09:10:14 +0000 (-0800) Subject: [PATCH] schedule_timeout(): improve warning message X-Git-Tag: v2.6.20-rc2~30 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=5b149bcc230e4696a1d893504bed38aeb3832314;p=linux-2.6-omap-h63xx.git [PATCH] schedule_timeout(): improve warning message Kyle is hitting this warning, and we don't have a clue what it's caused by. Add the obligatory dump_stack(). Cc: kyle Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/kernel/timer.c b/kernel/timer.c index feddf817baa..c2a8ccfc288 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1344,11 +1344,10 @@ fastcall signed long __sched schedule_timeout(signed long timeout) * should never happens anyway). You just have the printk() * that will tell you if something is gone wrong and where. */ - if (timeout < 0) - { + if (timeout < 0) { printk(KERN_ERR "schedule_timeout: wrong timeout " - "value %lx from %p\n", timeout, - __builtin_return_address(0)); + "value %lx\n", timeout); + dump_stack(); current->state = TASK_RUNNING; goto out; }