From: Oleg Nesterov <oleg@tv-sign.ru>
Date: Wed, 30 Apr 2008 07:52:36 +0000 (-0700)
Subject: signals: do_signal_stop(): use signal_group_exit()
X-Git-Tag: v2.6.26-rc1~311
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=573cf9ad72c13750e86c91de43477e9dfb440523;p=linux-2.6-omap-h63xx.git

signals: do_signal_stop(): use signal_group_exit()

do_signal_stop() needs signal_group_exit() but checks sig->group_exit_task.
 This (optimization) is correct, SIGNAL_STOP_DEQUEUED and SIGNAL_GROUP_EXIT
are mutually exclusive, but looks confusing.  Use signal_group_exit(), this
is not fastpath, the code clarity is more important.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/kernel/signal.c b/kernel/signal.c
index fb8ffd46885..29aca40be33 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1717,7 +1717,7 @@ static int do_signal_stop(int signr)
 		struct task_struct *t;
 
 		if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
-		    unlikely(sig->group_exit_task))
+		    unlikely(signal_group_exit(sig)))
 			return 0;
 		/*
 		 * There is no group stop already in progress.