From: Marcin Slusarz <marcin.slusarz@gmail.com>
Date: Sun, 2 Nov 2008 21:18:52 +0000 (+0100)
Subject: sata_via: restore vt*_prepare_host error handling
X-Git-Tag: v2.6.28-rc4~87^2~4
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=554d491de112a378b4d1a705bb93b58bcd444a70;p=linux-2.6-omap-h63xx.git

sata_via: restore vt*_prepare_host error handling

commit b9d5b89b487517cbd4cb4702da829e07ef9e4432 (sata_via: fix support
for 5287) accidently (?) removed vt*_prepare_host error handling - restore it

catched by gcc:
drivers/ata/sata_via.c: In function 'svia_init_one':
drivers/ata/sata_via.c:567: warning: 'host' may be used uninitialized in this function

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Joseph Chan <JosephChan@via.com.tw>
Cc: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---

diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 62367fe4d5d..c18935f0bda 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -602,8 +602,10 @@ static int svia_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		rc = vt8251_prepare_host(pdev, &host);
 		break;
 	default:
-		return -EINVAL;
+		rc = -EINVAL;
 	}
+	if (rc)
+		return rc;
 
 	svia_configure(pdev);