From: Amy Griffis <amy.griffis@hp.com>
Date: Tue, 1 Aug 2006 21:52:26 +0000 (-0400)
Subject: [PATCH] fix audit oops with invalid operator
X-Git-Tag: v2.6.18-rc4~61
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=5422e01ac16df7398b2bad1eccad0ae3be4dee32;p=linux-2.6-omap-h63xx.git

[PATCH] fix audit oops with invalid operator

Michael C Thompson wrote:  [Tue Aug 01 2006, 02:36:36PM EDT]
> The trigger for this oops is:
> # auditctl -a exit,always -S pread64 -F 'inode<1'

Setting the err value will fix it.

Signed-off-by: Amy Griffis <amy.griffis@hp.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 5b4e16276ca..32420f91402 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -442,6 +442,7 @@ static struct audit_entry *audit_rule_to_entry(struct audit_rule *rule)
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}
@@ -579,6 +580,7 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
 		case AUDIT_EQUAL:
 			break;
 		default:
+			err = -EINVAL;
 			goto exit_free;
 		}
 	}