From: Jan Glauber <jang@linux.vnet.ibm.com>
Date: Thu, 21 Aug 2008 17:46:33 +0000 (+0200)
Subject: [S390] qdio: prevent oopsing if qdio_establish fails
X-Git-Tag: v2.6.27-rc5~64
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=53b41ba7ce4563c33a0449fbcbbd70665477d654;p=linux-2.6-omap-h63xx.git

[S390] qdio: prevent oopsing if qdio_establish fails

If qdio_establish fails we call qdio_shutdown to cleanup the
qdio subchannel. The tiq_list entry may not be valid at that
time, therefore we must ignore queues with an invalid list entry
in tiqdio_remove_input_queues.

Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

diff --git a/drivers/s390/cio/qdio_thinint.c b/drivers/s390/cio/qdio_thinint.c
index 9291a771d81..ea7f6140026 100644
--- a/drivers/s390/cio/qdio_thinint.c
+++ b/drivers/s390/cio/qdio_thinint.c
@@ -113,7 +113,11 @@ void tiqdio_remove_input_queues(struct qdio_irq *irq_ptr)
 	struct qdio_q *q;
 	int i;
 
-	for_each_input_queue(irq_ptr, q, i) {
+	for (i = 0; i < irq_ptr->nr_input_qs; i++) {
+		q = irq_ptr->input_qs[i];
+		/* if establish triggered an error */
+		if (!q || !q->entry.prev || !q->entry.next)
+			continue;
 		list_del_rcu(&q->entry);
 		synchronize_rcu();
 	}