From: Laurent Pinchart <laurent.pinchart@skynet.be>
Date: Sat, 3 Jan 2009 23:08:26 +0000 (-0300)
Subject: V4L/DVB (10199): uvcvideo: Fix GET_DEF failure detection.
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=51cac8ada5caaade4eca0023042ceb01edd82840;p=linux-2.6-omap-h63xx.git

V4L/DVB (10199): uvcvideo: Fix GET_DEF failure detection.

Commit 44f0079ec74330b457d990072c13cbe28b0f1abf erroneously considers all
GET_DEF requests as unsuccessful. Fix this by checking the request return
value.

Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---

diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c
index f9eb0e97405..9bc4705be78 100644
--- a/drivers/media/video/uvc/uvc_video.c
+++ b/drivers/media/video/uvc/uvc_video.c
@@ -114,7 +114,7 @@ static int uvc_get_video_ctrl(struct uvc_video_device *video,
 		ctrl->wCompQuality = le16_to_cpup((__le16 *)data);
 		ret = 0;
 		goto out;
-	} else if (query == GET_DEF && probe == 1) {
+	} else if (query == GET_DEF && probe == 1 && ret != size) {
 		/* Many cameras don't support the GET_DEF request on their
 		 * video probe control. Warn once and return, the caller will
 		 * fall back to GET_CUR.