From: WANG Cong Date: Mon, 28 Apr 2008 09:13:57 +0000 (-0700) Subject: arch/um/os-Linux/sys-i386/task_size.c: improve a bit X-Git-Tag: v2.6.26-rc1~901 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=4415d8a5aaec2008833e1c474b38627c0bc738ca;p=linux-2.6-omap-h63xx.git arch/um/os-Linux/sys-i386/task_size.c: improve a bit Improve this code a bit: check sigaction's return value and remove a useless fflush(). Acked-by: Jeff Dike Signed-off-by: WANG Cong Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/arch/um/os-Linux/sys-i386/task_size.c b/arch/um/os-Linux/sys-i386/task_size.c index 48d211b3d9a..ccb49b0aff5 100644 --- a/arch/um/os-Linux/sys-i386/task_size.c +++ b/arch/um/os-Linux/sys-i386/task_size.c @@ -88,7 +88,10 @@ unsigned long os_get_task_size(void) sa.sa_handler = segfault; sigemptyset(&sa.sa_mask); sa.sa_flags = SA_NODEFER; - sigaction(SIGSEGV, &sa, &old); + if (sigaction(SIGSEGV, &sa, &old)) { + perror("os_get_task_size"); + exit(1); + } if (!page_ok(bottom)) { fprintf(stderr, "Address 0x%x no good?\n", @@ -110,11 +113,12 @@ unsigned long os_get_task_size(void) out: /* Restore the old SIGSEGV handling */ - sigaction(SIGSEGV, &old, NULL); - + if (sigaction(SIGSEGV, &old, NULL)) { + perror("os_get_task_size"); + exit(1); + } top <<= UM_KERN_PAGE_SHIFT; printf("0x%x\n", top); - fflush(stdout); return top; }