From: Ville Syrjala Date: Thu, 24 Jul 2008 04:31:27 +0000 (-0700) Subject: fbdev: width and height are unsigned X-Git-Tag: v2.6.27-rc1~555 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=43a3abc6aca8505e708508e2c7c2f99a7f8f820b;p=linux-2.6-omap-h63xx.git fbdev: width and height are unsigned The width and height members of fb_var_screeninfo are __u32. The code initializes them to -1 which seems wrong, and 0 seems like an equally good default value. Signed-off-by: Ville Syrjala Cc: "Antonino A. Daplas" Cc: Krzysztof Helt Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 052e1805849..6a0aa180c26 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -879,7 +879,7 @@ int fb_parse_edid(unsigned char *edid, struct fb_var_screeninfo *var) if (edid_is_timing_block(block)) { var->xres = var->xres_virtual = H_ACTIVE; var->yres = var->yres_virtual = V_ACTIVE; - var->height = var->width = -1; + var->height = var->width = 0; var->right_margin = H_SYNC_OFFSET; var->left_margin = (H_ACTIVE + H_BLANKING) - (H_ACTIVE + H_SYNC_OFFSET + H_SYNC_WIDTH);