From: Steven Rostedt <srostedt@redhat.com>
Date: Thu, 19 Feb 2009 18:41:27 +0000 (-0500)
Subject: ftrace: break out modify loop immediately on detection of error
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=4377245aa93b65b6597e4b7bb460fb9abc48b56b;p=linux-2.6-omap-h63xx.git

ftrace: break out modify loop immediately on detection of error

Impact: added precaution on failure detection

Break out of the modifying loop as soon as a failure is detected.
This is just an added precaution found by code review and was not
found by any bug chasing.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 72316d9647b..11ad796ca04 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -561,8 +561,11 @@ static void ftrace_replace_code(int enable)
 				if ((system_state == SYSTEM_BOOTING) ||
 				    !core_kernel_text(rec->ip)) {
 					ftrace_free_rec(rec);
-				} else
+				} else {
 					ftrace_bug(failed, rec->ip);
+					/* Stop processing */
+					return;
+				}
 			}
 		}
 	}