From: David S. Miller <davem@davemloft.net>
Date: Tue, 28 Feb 2006 19:55:36 +0000 (-0800)
Subject: [SUNSU]: Fix locking error in sunsu_stop_rx().
X-Git-Tag: v2.6.16-rc6~156
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=436002e3293472e4a7e47e5025999fc312794c4a;p=linux-2.6-omap-h63xx.git

[SUNSU]: Fix locking error in sunsu_stop_rx().

The caller takes the UART port lock, so we shouldn't try
to take it again.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c
index 30870456694..4e453fa966a 100644
--- a/drivers/serial/sunsu.c
+++ b/drivers/serial/sunsu.c
@@ -299,13 +299,10 @@ static void sunsu_start_tx(struct uart_port *port)
 static void sunsu_stop_rx(struct uart_port *port)
 {
 	struct uart_sunsu_port *up = (struct uart_sunsu_port *) port;
-	unsigned long flags;
 
-	spin_lock_irqsave(&up->port.lock, flags);
 	up->ier &= ~UART_IER_RLSI;
 	up->port.read_status_mask &= ~UART_LSR_DR;
 	serial_out(up, UART_IER, up->ier);
-	spin_unlock_irqrestore(&up->port.lock, flags);
 }
 
 static void sunsu_enable_ms(struct uart_port *port)