From: David Howells <dhowells@redhat.com>
Date: Fri, 9 Jan 2009 16:13:46 +0000 (+0000)
Subject: CRED: Must initialise the new creds in prepare_kernel_cred()
X-Git-Tag: v2.6.29-rc1~36
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=43529c97122f2c851126447963eedcb8cba74fbe;p=linux-2.6-omap-h63xx.git

CRED: Must initialise the new creds in prepare_kernel_cred()

The newly allocated creds in prepare_kernel_cred() must be initialised
before get_uid() and get_group_info() can access them.  They should be
copied from the old credentials.

Reported-by: Steve Dickson <steved@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/kernel/cred.c b/kernel/cred.c
index fc222e4acfb..043f78c133c 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -506,6 +506,7 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
 	else
 		old = get_cred(&init_cred);
 
+	*new = *old;
 	get_uid(new->user);
 	get_group_info(new->group_info);