From: Jiri Kosina <jkosina@suse.cz>
Date: Tue, 20 Feb 2007 00:33:39 +0000 (+0100)
Subject: HID: fix bug in zeroing the last field byte in output reports
X-Git-Tag: v2.6.21-rc3~147^2~5
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=4237081e573b99a48991aa71364b0682c444651c;p=linux-2.6-omap-h63xx.git

HID: fix bug in zeroing the last field byte in output reports

d4ae650a904612ffb7edd3f28b69b022988d2466 introduced zeroing of the
last field byte in output reports in order to make sure the unused
bits are set to 0. This is done in a wrong way, resulting in a
wrong bits being zeroed out (not properly shifted by the field offset
in the report). Fix this.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 7452399501b..aeeb6798e2f 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -880,7 +880,7 @@ static void hid_output_field(struct hid_field *field, __u8 *data)
 
 	/* make sure the unused bits in the last byte are zeros */
 	if (count > 0 && size > 0)
-		data[(count*size-1)/8] = 0;
+		data[(offset+count*size-1)/8] = 0;
 
 	for (n = 0; n < count; n++) {
 		if (field->logical_minimum < 0)	/* signed values */