From: Aron Griffis <aron@hp.com>
Date: Wed, 9 Jan 2008 03:29:38 +0000 (-0500)
Subject: [IA64] efi.c Add /* never reached */ annotation
X-Git-Tag: v2.6.25-rc1~785^2~9
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=410ab512e5c5716287a399145df0905c1dcddb04;p=linux-2.6-omap-h63xx.git

[IA64] efi.c Add /* never reached */ annotation

As written, this loop could be for (;;) instead of do while (md).  The tests
inside the loop always result in a return so the loop never terminates normally.

Signed-off-by: Aron Griffis <aron@hp.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---

diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
index 269f4f4adfe..d59134d7e73 100644
--- a/arch/ia64/kernel/efi.c
+++ b/arch/ia64/kernel/efi.c
@@ -762,7 +762,7 @@ efi_mem_attribute (unsigned long phys_addr, unsigned long size)
 		if (!md || (md->attribute & ~EFI_MEMORY_RUNTIME) != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 
 u64
@@ -798,7 +798,7 @@ kern_mem_attribute (unsigned long phys_addr, unsigned long size)
 		if (!md || md->attribute != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 EXPORT_SYMBOL(kern_mem_attribute);