From: Alan Cox Date: Mon, 13 Oct 2008 09:36:11 +0000 (+0100) Subject: serial_8250: pci_enable_device fail is not fully handled X-Git-Tag: v2.6.28-rc1~665 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=40836c484c31301998a14be0439cc4e856399843;p=linux-2.6-omap-h63xx.git serial_8250: pci_enable_device fail is not fully handled talking about leaks - I noticed that the 'check return of pci_enable_dev()' in the 8250 pci resume function finally made it in despite my objections against it (causing stuff in higher levels to leak). Signed-off-by: Alan Cox Signed-off-by: Linus Torvalds --- diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index c2f23933155..c014ffb110e 100644 --- a/drivers/serial/8250_pci.c +++ b/drivers/serial/8250_pci.c @@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev) * The device may have been disabled. Re-enable it. */ err = pci_enable_device(dev); + /* FIXME: We cannot simply error out here */ if (err) - return err; - + printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n"); pciserial_resume_ports(priv); } return 0;