From: Ben Hutchings Date: Tue, 6 May 2008 18:41:48 +0000 (+0100) Subject: Hold RTNL while calling dev_close() X-Git-Tag: v2.6.26-rc9~84^2~29 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=3e3cda96d014b69f7723d1d4507897e5be6aceb7;p=linux-2.6-omap-h63xx.git Hold RTNL while calling dev_close() dev_close() must be called holding the RTNL. Compile-tested only. Signed-off-by: Ben Hutchings Signed-off-by: Jeff Garzik --- diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index 249e18053d5..069f8bb0a99 100644 --- a/drivers/net/wan/x25_asy.c +++ b/drivers/net/wan/x25_asy.c @@ -32,6 +32,7 @@ #include #include #include +#include #include "x25_asy.h" #include @@ -601,8 +602,10 @@ static void x25_asy_close_tty(struct tty_struct *tty) if (!sl || sl->magic != X25_ASY_MAGIC) return; + rtnl_lock(); if (sl->dev->flags & IFF_UP) dev_close(sl->dev); + rtnl_unlock(); tty->disc_data = NULL; sl->tty = NULL;