From: Nick Piggin Date: Sun, 6 May 2007 21:49:05 +0000 (-0700) Subject: fs: buffer don't PageUptodate without page locked X-Git-Tag: v2.6.22-rc1~990 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=3d67f2d7c0fb28b0eb6a6aa100b190526a971ad9;p=linux-2.6-omap-h63xx.git fs: buffer don't PageUptodate without page locked __block_write_full_page is calling SetPageUptodate without the page locked. This is unusual, but not incorrect, as PG_writeback is still set. However the next patch will require that SetPageUptodate always be called with the page locked. Simply don't bother setting the page uptodate in this case (it is unusual that the write path does such a thing anyway). Instead just leave it to the read side to bring the page uptodate when it notices that all buffers are uptodate. Signed-off-by: Nick Piggin Cc: Hugh Dickins Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/buffer.c b/fs/buffer.c index 1d0852fa728..dcc5faa573b 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1700,17 +1700,8 @@ done: * clean. Someone wrote them back by hand with * ll_rw_block/submit_bh. A rare case. */ - int uptodate = 1; - do { - if (!buffer_uptodate(bh)) { - uptodate = 0; - break; - } - bh = bh->b_this_page; - } while (bh != head); - if (uptodate) - SetPageUptodate(page); end_page_writeback(page); + /* * The page and buffer_heads can be released at any time from * here on.