From: Adrian Bunk Date: Sat, 25 Mar 2006 11:07:50 +0000 (-0800) Subject: [PATCH] reiserfs/xattr_acl.c:reiserfs_get_acl(): make size an int X-Git-Tag: v2.6.17-rc1~784 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=3cdc409c169c9f2155151eea82cb9868e4d62788;p=linux-2.6-omap-h63xx.git [PATCH] reiserfs/xattr_acl.c:reiserfs_get_acl(): make size an int The Coverity checker wasn't happy seeing a size_t compared with -ENODATA and -ENOSYS. Since the only place where size is set is through the result of reiserfs_xattr_get() which is an int, we could simply make size an int. Signed-off-by: Adrian Bunk Cc: Jeff Mahoney Cc: Chris Mason Cc: Hans Reiser Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/reiserfs/xattr_acl.c b/fs/reiserfs/xattr_acl.c index ab8894c3b9e..58c418fbca2 100644 --- a/fs/reiserfs/xattr_acl.c +++ b/fs/reiserfs/xattr_acl.c @@ -182,7 +182,7 @@ struct posix_acl *reiserfs_get_acl(struct inode *inode, int type) { char *name, *value; struct posix_acl *acl, **p_acl; - size_t size; + int size; int retval; struct reiserfs_inode_info *reiserfs_i = REISERFS_I(inode); @@ -206,7 +206,7 @@ struct posix_acl *reiserfs_get_acl(struct inode *inode, int type) return posix_acl_dup(*p_acl); size = reiserfs_xattr_get(inode, name, NULL, 0); - if ((int)size < 0) { + if (size < 0) { if (size == -ENODATA || size == -ENOSYS) { *p_acl = ERR_PTR(-ENODATA); return NULL;