From: Andi Kleen <andi@firstfloor.org>
Date: Tue, 7 Oct 2008 01:37:44 +0000 (-0400)
Subject: ext4: Avoid double dirtying of super block in ext4_put_super()
X-Git-Tag: v2.6.28-rc1~709^2~1
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=39d80c33a068d9fa63a36c3b2c0d718d38440dd1;p=linux-2.6-omap-h63xx.git

ext4: Avoid double dirtying of super block in ext4_put_super()

While reading code I noticed that ext4_put_super() dirties the
superblock bh twice. It is always done in ext4_commit_super()
too. Remove the redundant dirty operation.
Should be a nop semantically.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9c0214689de..7d865608e81 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -512,8 +512,6 @@ static void ext4_put_super(struct super_block *sb)
 	if (!(sb->s_flags & MS_RDONLY)) {
 		EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
 		es->s_state = cpu_to_le16(sbi->s_mount_state);
-		BUFFER_TRACE(sbi->s_sbh, "marking dirty");
-		mark_buffer_dirty(sbi->s_sbh);
 		ext4_commit_super(sb, es, 1);
 	}
 	if (sbi->s_proc) {