From: Ralph Campbell Date: Tue, 23 Oct 2007 22:04:15 +0000 (-0700) Subject: IB/mad: Remove redundant NULL pointer check in ib_mad_recv_done_handler() X-Git-Tag: v2.6.25-rc1~1234^2~72 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=3828ff457a694f97f88f6978bea428199df0a690;p=linux-2.6-omap-h63xx.git IB/mad: Remove redundant NULL pointer check in ib_mad_recv_done_handler() In ib_mad_recv_done_handler(), the response pointer is checked for NULL after allocating it. It is then checked again in the local process_mad() path but there is no possibility of it changing in between. Signed-off-by: Ralph Campbell Acked-by: Hal Rosenstock Signed-off-by: Roland Dreier --- diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index 6f4287716ab..f82900d30b9 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -1931,15 +1931,6 @@ local: if (port_priv->device->process_mad) { int ret; - if (!response) { - printk(KERN_ERR PFX "No memory for response MAD\n"); - /* - * Is it better to assume that - * it wouldn't be processed ? - */ - goto out; - } - ret = port_priv->device->process_mad(port_priv->device, 0, port_priv->port_num, wc, &recv->grh,