From: Pablo Neira Ayuso <pablo@eurodev.net>
Date: Wed, 10 Aug 2005 03:06:11 +0000 (-0700)
Subject: [NETFILTER]: fix conntrack refcount leak in unlink_expect()
X-Git-Tag: v2.6.14-rc1~1035^2~180
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=37012f7fd326eb3c959428a4fe7e203e6304fe43;p=linux-2.6-omap-h63xx.git

[NETFILTER]: fix conntrack refcount leak in unlink_expect()

In unlink_expect(), the expectation is removed from the list so the
refcount must be dropped as well.

Signed-off-by: Pablo Neira Ayuso <pablo@eurodev.net>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/netfilter/ip_conntrack_core.c b/net/ipv4/netfilter/ip_conntrack_core.c
index dace93eacc5..9261388d5ac 100644
--- a/net/ipv4/netfilter/ip_conntrack_core.c
+++ b/net/ipv4/netfilter/ip_conntrack_core.c
@@ -204,6 +204,7 @@ static void unlink_expect(struct ip_conntrack_expect *exp)
 	list_del(&exp->list);
 	CONNTRACK_STAT_INC(expect_delete);
 	exp->master->expecting--;
+	ip_conntrack_expect_put(exp);
 }
 
 void __ip_ct_expect_unlink_destroy(struct ip_conntrack_expect *exp)