From: Dmitry Torokhov Date: Fri, 29 Jun 2007 05:06:35 +0000 (-0400) Subject: Input: serio - take drv_mutex in serio_cleanup() X-Git-Tag: v2.6.22~23^2~2 X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=33143ea1a34d12699e6aa222ba124498abcfe4d1;p=linux-2.6-omap-h63xx.git Input: serio - take drv_mutex in serio_cleanup() We need to take serio->drv_mutex in serio_cleanup() to prevent the function from being called while driver is in the middle of attaching to a serio port. Such situation can happen with i8042 and atkbd drivers if user rapidly presses Ctrl-Alt-Del during system startup, and leads to kernel oops. Reported-by: Dave Young Signed-off-by: Dmitry Torokhov --- diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c index 5895202b972..a8f3bc1dff2 100644 --- a/drivers/input/serio/serio.c +++ b/drivers/input/serio/serio.c @@ -769,8 +769,10 @@ static int serio_driver_remove(struct device *dev) static void serio_cleanup(struct serio *serio) { + mutex_lock(&serio->drv_mutex); if (serio->drv && serio->drv->cleanup) serio->drv->cleanup(serio); + mutex_unlock(&serio->drv_mutex); } static void serio_shutdown(struct device *dev)