From: Patrick McHardy <kaber@trash.net>
Date: Mon, 13 Mar 2006 04:40:43 +0000 (-0800)
Subject: [NETFILTER]: arp_tables: fix NULL pointer dereference
X-Git-Tag: v2.6.16~49
X-Git-Url: http://pilppa.com/gitweb/?a=commitdiff_plain;h=31fe4d331729e9687db84521c3ceb8e43390efcf;p=linux-2.6-omap-h63xx.git

[NETFILTER]: arp_tables: fix NULL pointer dereference

The check is wrong and lets NULL-ptrs slip through since !IS_ERR(NULL)
is true.

Coverity #190

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index dd1048be8a0..7d7ab94a7a2 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -771,7 +771,7 @@ static int get_entries(const struct arpt_get_entries *entries,
 	struct arpt_table *t;
 
 	t = xt_find_table_lock(NF_ARP, entries->name);
-	if (t || !IS_ERR(t)) {
+	if (t && !IS_ERR(t)) {
 		struct xt_table_info *private = t->private;
 		duprintf("t->private->number = %u\n",
 			 private->number);